LibGfx: Use libwebp #636
Open
LibGfx: Use libwebp #636
+153
−3,647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches libwebp (see ZeroFillCanvas() call in libwebp/src/demux/anim_decode.c:355 and ZeroFillFrameRect() call in line 435, but in WebPAnimDecoderGetNext()) and makes files written e.g. by asesprite look correct -- even though the old behavior is also spec-compliant and arguably makes more sense. Now nothing looks at the background color stored in the file. See PR for an example image where it makes a visible difference.
ADKaster
reviewed
Jul 15, 2024
Comment on lines
+137
to
+138
| uint8_t* frame_data; | ||
| int timestamp; |
There was a problem hiding this comment.
please always initialize basic types, even if they're expected to be overridden by a function call.
| State state { State::NotDecoded }; | ||
| ReadonlyBytes data; | ||
|
|
||
| ReadonlyBytes chunks_cursor; | ||
|
|
||
| // Image properties | ||
| Optional<IntSize> size; |
There was a problem hiding this comment.
I know that you didn't write that, but this shouldn't be an Optional
Comment on lines
+111
to
+112
| context.icc_data.resize(icc_profile.size); | ||
| memcpy(context.icc_data.data(), icc_profile.bytes, icc_profile.size); |
There was a problem hiding this comment.
I think that it can be replaced by ByteBuffer::copy
| WebPAnimDecoderOptions anim_decoder_options {}; | ||
| WebPAnimDecoderOptionsInit(&anim_decoder_options); | ||
| anim_decoder_options.color_mode = MODE_BGRA; | ||
| anim_decoder_options.use_threads = 1; |
There was a problem hiding this comment.
Why do we set that rather than letting the default value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use libwebp to do decoding of webp images, dropping the existing code. A number of tests are altered to match new conversion, this is largely expected since the YUV->RGB conversion isn't bit-exact, and the results were compared visually. Resolves #593.