Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/LibWasm: Mark two static functions "static" #646

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

alimpfard
Copy link
Contributor

-Wmissing-declarations would complain about these.

@nico
Copy link
Contributor

nico commented Jul 15, 2024

Static is enough, no need for inline. This ain't C.

@nico
Copy link
Contributor

nico commented Jul 15, 2024

(...static would be enough in C too, but just inline is often spelled static inline in headers that are shared between c and c++)

-Wmissing-declarations would complain about these.
@alimpfard
Copy link
Contributor Author

😭 no bully Cbrain

@alimpfard alimpfard changed the title Tests/LibWasm: Mark two static functions "static inline" Tests/LibWasm: Mark two static functions "static" Jul 15, 2024
@alimpfard alimpfard merged commit 4ef909c into LadybirdBrowser:master Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants