Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Restore event characteristics of MouseEvents #667

Merged
merged 2 commits into from
Jul 16, 2024
Merged

LibWeb: Restore event characteristics of MouseEvents #667

merged 2 commits into from
Jul 16, 2024

Conversation

circl-lastname
Copy link
Contributor

Fixes #660
Contributes to #102

@circl-lastname circl-lastname mentioned this pull request Jul 16, 2024
Open
13 tasks
@circl-lastname
Copy link
Contributor Author

circl-lastname commented Jul 16, 2024 •
edited
Loading

cc: @caitp @tcl3
The fix was simple, as the spec requires these in all usages except mouseenter and mouseleave

kalenikaliaksandr
kalenikaliaksandr requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@kalenikaliaksandr kalenikaliaksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, would you add a test please, so we won't regress this in the future.

@kalenikaliaksandr
Copy link
Contributor

we need to make the same change for WheelEvent, right?

@circl-lastname
Copy link
Contributor Author

circl-lastname commented Jul 16, 2024 •
edited
Loading

Yes, both would be nice

@circl-lastname
Copy link
Contributor Author

Can it be merged now?

@kalenikaliaksandr kalenikaliaksandr merged commit 89531fb into LadybirdBrowser:master Jul 16, 2024
6 checks passed
@circl-lastname circl-lastname deleted the fix_event_characteristics branch July 16, 2024 18:12
@circl-lastname circl-lastname mentioned this pull request Jul 16, 2024
Merged
@caitp
Copy link
Contributor

caitp commented Jul 16, 2024

Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalenikaliaksandr kalenikaliaksandr kalenikaliaksandr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LibWeb: Picker for <select> elements isn't shown on click
3 participants
@circl-lastname @kalenikaliaksandr @caitp