This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
store Blacklight results in app state #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to navigate through previous searches using the back/forward button in their browser and will update the search accordingly. Fixes #85
This allows us to use Blacklight's defaults without explicitly stating them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins the work towards revamping the way we handle search results by moving them up a level into the app state. The SearchResults page still uses its own internal state to display the results, but that may be refactored out down the road to rely solely on props passed via Redux.
This also includes a few refactor/cleanups:
SearchBreadcrumbTrailcomponent within the SearchResults pageactions/search.js, instead relying on Blacklight to provide reasonable defaultsAs well as a bugfix:
page/SearchResults.jsxis now updated when users navigate using the browser's back/forward buttons.Fixes #85