Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to send a "turn on" command before any brightness control. #67

Closed
LaggAt opened this issue Oct 13, 2020 · 1 comment
Closed

Option to send a "turn on" command before any brightness control. #67

LaggAt opened this issue Oct 13, 2020 · 1 comment
Assignees
@LaggAt
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@LaggAt
Copy link
Owner

LaggAt commented Oct 13, 2020 •
edited

H6104 is not turning on, when just sending a brightness > 0.

We need an option per device, where we could configure the device to always send a turn_on before a brightness command.
This could be persisted in the learning, and - when learning - should default to false, except for H6104 to true.

New optional option in learning will be:
before_set_brightness_turn_on: false

see also:
https://community.home-assistant.io/t/govee-led-strips-integration/228516/129?u=laggat
@LaggAt LaggAt added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Oct 13, 2020
@LaggAt LaggAt self-assigned this Oct 13, 2020
LaggAt added a commit that referenced this issue Oct 21, 2020
@LaggAt
turn before brightness #67, storage example, tests
ba62150
LaggAt added a commit that referenced this issue Oct 21, 2020
@LaggAt
Merge pull request #68 from LaggAt/bug/67_turn_on_before_brightness
3a35cc5 
turn before brightness #67, storage example, tests
@LaggAt LaggAt closed this as completed Oct 21, 2020
@LaggAt
Copy link
Owner Author

LaggAt commented Oct 21, 2020

see https://community.home-assistant.io/t/govee-led-strips-integration/228516/141?u=laggat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LaggAt LaggAt

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LaggAt