Build updates #44
Merged
Build updates #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jawnnypoo
commented
Jun 4, 2024
Jawnnypoo
commented
- Build with Java 17
- Build with Kotlin 1.9.20
- Remove some unused/unneeded things
Laimiux
reviewed
Jun 10, 2024
| @@ -11,26 +11,26 @@ import io.reactivex.rxjava3.core.Maybe | |||
| import io.reactivex.rxjava3.core.Observable | |||
| import io.reactivex.rxjava3.core.Single | |||
|
|
|||
| inline fun <C, E> Completable.toUCE( | |||
| inline fun <C: Any, E> Completable.toUCE( | |||
There was a problem hiding this comment.
Type changes within Kotlin/RxJava interop
There was a problem hiding this comment.
I don't think Completable needs it?
There was a problem hiding this comment.
Since we call toSingleDefault on the completable, it is needed.
Laimiux
reviewed
Jun 10, 2024
lce-test/build.gradle
Outdated
| kotlinOptions { | ||
| jvmTarget = "1.8" | ||
| java { | ||
| toolchain { |
Laimiux
requested changes
Jun 10, 2024
|
Fixed 👍 |
Laimiux
reviewed
Jun 17, 2024
| @@ -14,11 +14,12 @@ jobs: | |||
| - uses: gradle/wrapper-validation-action@v1 | |||
| - uses: actions/setup-java@v1 | |||
| with: | |||
| java-version: 11 | |||
| distribution: 'zulu' | |||
| java-version: 17 | |||
There was a problem hiding this comment.
https://developer.android.com/build/jdks#target-compat since its a library and not an application, I think its safer to go with 17
Laimiux
reviewed
Jun 17, 2024
| } | ||
|
|
||
| dependencies { | ||
| api(project(":lce")) |
There was a problem hiding this comment.
side-note: would be nice to introduce projects.lce statically typed accessors.
Laimiux
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.