Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort array with 0,1,2 #211

Closed
wants to merge 2 commits into from
Closed

sort array with 0,1,2 #211

wants to merge 2 commits into from

Conversation

Nanzzie
Copy link

@Nanzzie Nanzzie commented Mar 2, 2022

Related Issue

  • Mention issue for which this pull request is a part of (please mention issue number # )

Proposed Changes

  • Change 1
  • Chnage 2

Additional Info

  • Any additional information or context

Checklist

  • βœ… My code follows the code style of this project.
  • πŸ“ My change requires a change to the documentation.
  • πŸŽ€ I have updated the documentation accordingly.
  • πŸ‘€ I have read the CONTRIBUTING document.
  • ✨ I have added tests to cover my changes.
  • 🚩 All new and existing tests passed.
  • 🌟 ed the repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1 Screenshot #2
Title goes here Title goes here
Image goes here Image goes here

@Lakhankumawat
Copy link
Owner

Duplicate #165

@Lakhankumawat
Copy link
Owner

Few things to keep in mind while contributing next time

  1. ScreenShots of your code and working output in pR
  2. Make your PR descriptive
  3. No README Changes
  4. Faulty checks in checklist things are not actually done but checked in checklist i.e. README

@Lakhankumawat
Copy link
Owner

  1. Short Description or CheckLists

Make sure your Pull Request is descriptive and complete the checklist .
I would recommend you to go through this tutorial video of the project here ,thanks.

///------------------Descriptoin -----------------------///

For contribution and more guidelines i would recommend you to go through this
tutorial video of the project here, thanks.

///-----------------CheckList-------------------------///
Make sure your Pull Request is descriptive and complete the checklist .
I would recommend you to go through this tutorial video of the project here ,thanks.

///------------------Description -----------------------///

Let me show you how to check the check list , there should be no space inside brackets like [x]
[x]

  • Checklist
  • Or you can just check them from outside without doing any of these
  • ✨ I have added tests to cover my changes.
  • 🚩 All new and existing tests passed.
  • 🌟 ed the repo
  1. Starr the repo if you haven't !
  2. Have you watched this video ?

///----------------------PR README --------------------///

You need to follow particular guidelines for your README , please follow
these guidelines click here
also you can see how your README should look like see here
for more please go through these here

@Lakhankumawat Lakhankumawat added incomplete-checks invalid This doesn't seem right short-desc wontfix This will not be worked on labels Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete-checks invalid This doesn't seem right short-desc wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants