Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of Islands #247

Closed
wants to merge 3 commits into from
Closed

Conversation

ishitagupta014
Copy link

@ishitagupta014 ishitagupta014 commented Mar 2, 2022

Related Issue

Proposed Changes

  • Problem and Code in the file
  • Readme (Contains Problem description and example and Approach)

Checklist

  • βœ… My code follows the code style of this project.

  • πŸ“ My change requires a change to the documentation.

  • πŸŽ€ I have updated the documentation accordingly.

  • πŸ‘€ I have read the CONTRIBUTING document.

  • ✨ I have added tests to cover my changes.

  • 🚩 All new and existing tests passed.

  • 🌟 ed the repo

  • This pull request contains the solution of the issue Number of Islands Number of Islands Β #159

  • It fixes the issue created by me for the addition of a problem in G-Graphs Section

  • It contains a readme file that contains problem Description and a file that contains code for the given problems with a proper description of comments.

  • It has passed all the test cases and I have attached screenshots of two test cases as well.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

Screenshot #1 Screenshot #2
Testcase1 Testcase2

|
Screenshot 2022-01-14 205915
|
univalued
|

Copy link
Owner

@Lakhankumawat Lakhankumawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Code looks good but you can still modify your README
You need to follow particular guidelines for your README , please follow
these guidelines click here
also you can see how your README should look like see here
for more please go through these here

@Lakhankumawat
Copy link
Owner

Similar Problem is present here so justify in comments you have not copied from here !?

@Lakhankumawat
Copy link
Owner

Lakhankumawat commented Mar 3, 2022

  1. Starr the repo if you haven't !
  2. Have you watched this video ?
  3. Please complete the checklists only if you have done them , i see you haven't starred the repo yet but checked it in checklist.

@ishitagupta014
Copy link
Author

  1. Starr the repo if you haven't !
  2. Have you watched this video ?
  3. Please complete the checklists only if you have done them , i see you haven't starred the repo yet but checked it in checklist.

Hello @Lakhankumawat sir I have added more description of problem in README.md and have starred the repo as well. Please review my pr

@Lakhankumawat Lakhankumawat added the g2m These are PR'S handled by Miraj label Mar 5, 2022
@miraj0507
Copy link

Hello contributor, upon going through the PR it seems to have been beautifully presented but the description and also the images used without acknowledging the source, falls under plagiarism, Your description had 70% plagiarised when run through the software, It violates the guidelines.

@Lakhankumawat
Copy link
Owner

closed #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants