Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Profile Screen #8 #23

Closed

Conversation

Ashish-AI
Copy link

Related Issue

Proposed Changes

  • Add Profile Landing screen
  • Remove unused imports for few file
  • Add SVGs (icons)

Checklist

  • βœ… My code follows the code style of this project.
  • πŸ“ My change requires a change to the documentation.
  • πŸŽ€ I have updated the documentation accordingly.
  • πŸ‘€ I have read the CONTRIBUTING document.
  • ✨ I have added tests to cover my changes.
  • 🚩 All new and existing tests passed.
  • 🌟 ed the repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots

| Screenshot #1 |
| ----------- | ----------- |
| Profile Landing Sreen |
Screenshot_2022-03-05-22-36-36-43_156b98136834c1c0c80dbf8c5346c3f4

@chandan0000
Copy link
Collaborator

@Ashish-AI improve your design then make a video

@Ashish-AI
Copy link
Author

@chandan0000 What kind of changes do you want in the UI?

@chandan0000
Copy link
Collaborator

chandan0000 commented Mar 7, 2022

@Ashish-AI Icons and font size is not comfortable and padding and margin issue

@Ashish-AI
Copy link
Author

font size can appear different because of the fact that we are using a different font than what we are using on figma. Rest everything is designed as per Figma.
The function dedicated to handling the responsiveness is not giving the expected output. So some adjustments are made by reducing the size.

@Lakhankumawat
Copy link
Owner

YOUR PR IS Okay @Ashish-AI but we will be setting up a workflow for PR testing in REpo so we will be using your PR as test for few days don't worry it will not change or it will be fine and you'll get your PR merged and you'll get all your points , thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants