Compatible with return types, PHP 7.1 & Sylius 1.0 (fixes #60) #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Stefan, could you update travis config to only run tests for PHP 7.1 and modify composer to allow for Sylius 1.0, so we can see if we need any more codebase updates to be compatible with stable release? |
|
@michalmarcinkowski This should do it, I think. |
stefandoorn
changed the title
|
Thanks Stefan! 👍 Looks good! 🏅 |
|
Can we also have a release tagged maybe that's 1.0 supported? Or do you want to wait for more testing? I'm in my free time upgrading a project to 1.0 in which it seemed to work with my latest PR. |
|
Released v1.0.0-beta, after some time if there will be no issues we can tag v1.0 stable 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CmsPlugin compatible with latest version of Sylius (especially that 1.0 is getting close).