Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Elastica Grid driver from Sylius/Sylius PR #1

Open
pjedrzejewski opened this issue Dec 14, 2016 · 6 comments
Open

Migrate the Elastica Grid driver from Sylius/Sylius PR #1

pjedrzejewski opened this issue Dec 14, 2016 · 6 comments
Assignees

Comments

@pjedrzejewski
Copy link
Contributor

@Niiko

Sylius/Sylius#5756

We should migrate the driver here to kickstart the development of this bundle. Are you willing to submit a PR here or we somehow get your commits here?

@Niiko
Copy link

Niiko commented Dec 14, 2016

Yes no problem :)

@pjedrzejewski pjedrzejewski added this to the v1.0.0-alpha.1 milestone Dec 14, 2016
@pjedrzejewski
Copy link
Contributor Author

@Niiko Great, so @Arminek will setup the initial structure of this bundle, so that you can run Behat scenarios and everything and then we would need you to open your initial PR here. :) Thanks for your help!

@Niiko
Copy link

Niiko commented Dec 14, 2016

Perfect :)

@Arminek
Copy link
Contributor

Arminek commented Dec 15, 2016

Hi @Niiko when #6 will be merged you can open pr with your driver and it would be great if you will apply some changes from comments here Sylius/Sylius#5756. Also you don't have to register those services i will combine your commits with #7 and make it works 🎉 .

@Niiko
Copy link

Niiko commented Dec 15, 2016

Hi @Arminek ok, will do that :) thanks for support

@Niiko
Copy link

Niiko commented Jan 17, 2017

Hi @Arminek, due to sylius issue closed, i'm a little bit confused on how to contribute.

If i'm correct, driver can still be included and has to be for grid usage no ? Otherwise we can't use it for.

Just have to make it compliant with the new engine and match method, right ?

Arminek pushed a commit to Arminek/SyliusElasticSearchBundle that referenced this issue May 31, 2017
[ElasticSearch] Rename & remove ui & bump dsl to 5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants