New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.4 support #202
1.20.4 support #202
Conversation
Despite lighting being about the same as the one in 1.20.2, PR seems to be functioning properly including all GUI pages. edit: the GUI however seems to be super dark in terms of transparency, unsure if that was intentional. |
I think this is from the SpruceUI library. |
PR seems to work well in 1.20.4! |
I was also able to build from this branch and run in 1.20.4! |
Works flawlessly on 1.20.4 |
if possible can a maintainer approve the workflow so that the branch could be merged? |
@LambdAurora Can you merge this? |
It doesn't seem to work if indium is installed |
Thanksss! |
I didn't have any issues with indium when I tried it. What exactly isn't working? Does the game launch, can you open a world without it crashing, is the dynamic lighting just not working in-game? |
It's not that Indium doesn't work, but that LambDynamicLights almost doesn't work if Indium is installed. I'm Japanese so I used Google Translate, sorry for the bad English. |
Changes:
WorldMixin.java
atonBlockEntityTick
to match new method signature BlockEntityTickInvokerFixes #200
Fixes #204
Note: I'm fairly new to the client modding scene. I only tested the lighting part.