Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.4 support #202

Merged
merged 1 commit into from Feb 2, 2024
Merged

1.20.4 support #202

merged 1 commit into from Feb 2, 2024

Conversation

joestr
Copy link
Contributor

@joestr joestr commented Dec 21, 2023

Changes:

  • Bump dependencies
  • Modify method Mixin signature in WorldMixin.java at onBlockEntityTick to match new method signature BlockEntityTickInvoker

Fixes #200
Fixes #204

Note: I'm fairly new to the client modding scene. I only tested the lighting part.

@Kichura
Copy link

Kichura commented Dec 21, 2023

Despite lighting being about the same as the one in 1.20.2, PR seems to be functioning properly including all GUI pages.

edit: the GUI however seems to be super dark in terms of transparency, unsure if that was intentional.

@joestr
Copy link
Contributor Author

joestr commented Dec 21, 2023

edit: the GUI however seems to be super dark in terms of transparency, unsure if that was intentional.

I think this is from the SpruceUI library.

@TreyRuffy
Copy link

PR seems to work well in 1.20.4!

@ajamesmichaels
Copy link

I was also able to build from this branch and run in 1.20.4!

@tocram1 tocram1 mentioned this pull request Dec 29, 2023
@amyipdev
Copy link

amyipdev commented Jan 1, 2024

Works flawlessly on 1.20.4

@DovydasTEDS
Copy link

if possible can a maintainer approve the workflow so that the branch could be merged?

@DovydasTEDS
Copy link

@LambdAurora Can you merge this?

@KAGUYA-1137
Copy link

KAGUYA-1137 commented Jan 23, 2024

It doesn't seem to work if indium is installed

@SA64BD
Copy link

SA64BD commented Jan 26, 2024

Thanksss!

@cptlobster
Copy link

It doesn't seem to work if indium is installed

I didn't have any issues with indium when I tried it. What exactly isn't working? Does the game launch, can you open a world without it crashing, is the dynamic lighting just not working in-game?

@KAGUYA-1137
Copy link

インジウムが取り付けられていると動作しないようです

試してみたところ、インジウムに問題はありませんでした。具体的に何がうまくいっていないのでしょうか?ゲームが起動し、クラッシュせずに世界を開くことができますか、動的ライティングがゲーム内で機能していませんか?

It's not that Indium doesn't work, but that LambDynamicLights almost doesn't work if Indium is installed.
The reason I say almost is because non-solid blocks such as tall grass were affected by LambDynamicLights, but solid blocks such as stone and deepslate were not affected by LambDynamicLights.

I'm Japanese so I used Google Translate, sorry for the bad English.

@LambdAurora LambdAurora changed the base branch from 1.20.2 to 1.20.4 February 2, 2024 23:14
@LambdAurora LambdAurora merged commit 03b7222 into LambdAurora:1.20.4 Feb 2, 2024
2 checks passed
@joestr joestr deleted the 1.20.4-support branch February 3, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minecraft keeps crashing 1.20.3/4 Support