Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server th add papaparse #91

Merged
5 commits merged into from
Feb 28, 2019
Merged

Server th add papaparse #91

5 commits merged into from
Feb 28, 2019

Conversation

timOTdev
Copy link

@timOTdev timOTdev commented Feb 28, 2019 •
edited
Loading

-add papaparse to sendgrid flow
-change first and last name on the helpers of server folder
-pair programmed with Justin and Chaya

@timOTdev timOTdev requested review from a user and chayaotikor February 28, 2019 19:48
chayaotikor
chayaotikor approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@chayaotikor chayaotikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair programmed this, all good!

ghost
ghost approved these changes Feb 28, 2019
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! But it's failing the tests.

@ghost ghost merged commit ce6ac61 into master Feb 28, 2019
@ghost ghost deleted the server_th_addPapaparse branch February 28, 2019 20:07
@ghost ghost restored the server_th_addPapaparse branch February 28, 2019 21:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayaotikor chayaotikor chayaotikor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timOTdev @chayaotikor