Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Routes, styling & added progress graph #39

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

ielvisd
Copy link
Contributor

@ielvisd ielvisd commented Jan 17, 2019

Tested and updated routes
Styling for register, login routes and workout views
Progress Graph created for Each Metric

Co-authored-by: Matt Wright matthewbwright@gmail.com
Co-authored-by: Elvis Ibarra ielvisd@gmail.com

Description

Styling updated for register/login & workout views.
Routes updated and tested (workouts, users, exercises & categories)

Fixes # (issue)
User id is now on the token which needed to be updated for many routes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

Tested using Insomnia and inspector.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
    Ran insomnia calls to test the updated routes.
  • Test B
    Checked console.logs in inspector to make sure all data was passed correctly and styles displayed correctly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts

Tested and updated routes
Styling for register, login routes and workout views

Co-authored-by: Matt Wright <matthewbwright@gmail.com>
Co-authored-by: Elvis Ibarra <ielvisd@gmail.com>
Copy link
Contributor

@mattwright42 mattwright42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good.

@tgreenhalgh tgreenhalgh merged commit 88844c8 into master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants