Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Enhancement] DEBUG flag should not be hard-coded #349

Closed
WeAthFoLD opened this issue May 27, 2016 · 0 comments
Closed

[Code Enhancement] DEBUG flag should not be hard-coded #349

WeAthFoLD opened this issue May 27, 2016 · 0 comments

Comments

@WeAthFoLD
Copy link
Member

Currently, the DEBUG flag is hardcoded in AcademyCraft class:

public class AcademyCraft {
    public static final boolean DEBUG = <???>;
}

This causes problem in development. When we are developing it's natural to have that flag on, but when release that flag should be off. Manually changing it is tedious and error-prone.

Some alternatives:

  • Specified through the execution parameter. That will make this flag not inlined and slow down things a little bit, but I don't think that really matters much.
  • Set that flag off when using gradle build, but on when in developement env. I don't know if this is even approachable.
@WeAthFoLD WeAthFoLD changed the title DEBUG flag should not be hard-coded [Code Enhancement] DEBUG flag should not be hard-coded May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant