Rewrite + Refactor PlayerCB, PChar (gdscript one), and LimitedQueue stuff (NOT npcs)
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lamby777
added
rust
Lamby777
added a commit
that referenced
this pull request
Nov 4, 2023
Rewrite + Refactor `PlayerCB`, `PChar` (gdscript one), and `LimitedQueue` stuff (NOT npcs)
IIIzP0III
pushed a commit
to IIIzP0III/PETS-G
that referenced
this pull request
Nov 5, 2023
Rewrite + Refactor `PlayerCB`, `PChar` (gdscript one), and `LimitedQueue` stuff (NOT npcs) Former-commit-id: 731f14b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yes, i unironically "rewrote it in rust" for more shrimplicity.
also PlayerCB no longer just has the party members built in, and it can load and instantiate whatever using a macro... should prob think about how i'd implement removing such nodes tho
And it's like I predicted the future... YET AGAIN, I made a branch for NPCs and it ended up being for... not NPCs.