Update the tests to use fixtures in the GOV.UK Package #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-s-ccs
force-pushed
the
use-govuk-frontend-fixtures-for-tests
branch
2 times, most recently
from
67a2ccd
to
8239e25
Compare
…s generated as part of the GOV.UK Frontend package. This removes the need to use and maintain the `govuk-frontend-diff` project. I know in the `govuk-frontend-diff` project it’s set up to give quite a detailed diff if the generated HTML does not match and the way I’ve set it up, to compare using xmldiff, may not be quite what you’re after. I’m happy for any ideas to improve this.
tim-s-ccs
force-pushed
the
use-govuk-frontend-fixtures-for-tests
branch
from
8239e25
to
9583988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #76
I’ve updated the project to test the Jinja macros against the fixtures generated as part of the GOV.UK Frontend package.
This removes the need to use and maintain the
govuk-frontend-diffproject.I know in the
govuk-frontend-diffproject it’s set up to give quite a detailed diff if the generated HTML does not match and the way I’ve set it up, to compare usingxmldiff, may not be quite what you’re after. I’m happy for any ideas to improve this.