Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an improperly placed spawn mod #4877

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

CatsEyeXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Being intentionally vague in the PR title:
This mobID belongs to Cemetery Cherry, therefore Loot Bat.
image

Steps to test these changes

Kill the bat and you won't receive 30k gil.

Copy link
Contributor

@TeoTwawki TeoTwawki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened: IDs in the zone (King Ranperre's Tomb) shifted because new high lv mobs for master levels were added to the zones. That's right, mob IDs can shift. Like I've been warning people about since forever. Sweet sweet vindication.

This is why the whole file needs to die.

@zach2good zach2good merged commit 5657ddd into LandSandBoat:base Dec 19, 2023
13 checks passed
@CatsEyeXI CatsEyeXI deleted the loot_bat branch May 10, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants