Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua/sql] Correct Diabolos avatar animations and migrate to petskills #5595

Merged
merged 4 commits into from
May 5, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 3, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Finishing the work of @N3ckB3ard (re: these PRs), This is the last smn avatar that is coded I believe

Commits by NB:

  • Petskill animations, etc all pulled from captures
  • abilities updated to fit the new format for petskill consumption

Commits by me:

  • updated all diabolos pet lua files to use new helper functions
  • confirmed existing petskills still work
  • put notes in pet_skills.sql for ones that don't have a lua (and made an issue)
  • confirmed ranges of player abilities and petskills using the color of the reticle to determine max range. Examples:
    • Matched buffs to other petskills to have range of 18
    • stun pet, dream shroud, selecting myself for DS or noctoshield gives a red reticle at 20 yalms
    • unstun pet, select nether blast, move around to see the color change based on the pet's distance from the mob
      • camisodo has slightly longer range than somnolence
  • Note that the abilities have a range of 15, which means the player must get within 15 of the target, then the range of the pet to the target is checked when the skill goes off

Steps to test these changes

Load it up, use the abilities, see proper behavior/messages:

Dream shroud has a special set of message ids:
image
image

Somnolence wasn't getting the final adjustments (which apply magic burst message now), so that was added
image

@MowFord MowFord force-pushed the diabolos_petskills branch 2 times, most recently from 99cfa2d to f598e11 Compare May 3, 2024 16:11
@MowFord
Copy link
Contributor Author

MowFord commented May 3, 2024

Sorry about the multiple pushes. Had reworked the enum name for Dream Shroud and found that i had a few issues in the dream_shroud.lua during final testing.

PR is ready now

@claywar claywar merged commit 6d19fe7 into LandSandBoat:base May 5, 2024
11 checks passed
@CatsEyeXI CatsEyeXI deleted the diabolos_petskills branch May 13, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants