Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP] Fix possessive messages for players #5602

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 3, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes an issue where messages relating to the player were not possessive. Resolves #5600.

Steps to test these changes

  1. Give yourself paralyze (!exec target:addStatusEffect(xi.effect.PARALYSIS, 100, 0, 90))
  2. Attack a mob
  3. Alternatively use an ability on yourself or ready a weaponskill or let an effect fall off

image
image
image
image

@claywar claywar merged commit 68319dd into LandSandBoat:base May 3, 2024
12 checks passed
@ampitere ampitere deleted the fix_possessive_messages_for_players branch May 3, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Possessives for players are not right
3 participants