Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix underflow for slow mobs and negative mobspeedmod #5603

Merged
merged 1 commit into from May 11, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 3, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Troubleshooting Royal Jelly, i ran across a pretty silly bug. My local has MOB_SPEED_MOD = -10 and the princess jellies have speed of 2... so they were underflow zooming to the center

Steps to test these changes

Set map setting for mob_speed_mod negative, give a mob a speed such that this would be negative.

before:
https://imgur.com/f5eao3Q

after:
https://imgur.com/OmgTfXv

@MowFord MowFord force-pushed the mob_speed_mod branch 2 times, most recently from c1dfb79 to 477f2ae Compare May 4, 2024 22:53
settings/default/map.lua Outdated Show resolved Hide resolved
settings/default/map.lua Outdated Show resolved Hide resolved
This fixes underflow for slow mobs and negative mobspeedmod
Copy link
Contributor

@TeoTwawki TeoTwawki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 'nuff methinks

@claywar claywar merged commit c1ae7a6 into LandSandBoat:base May 11, 2024
11 checks passed
@CatsEyeXI CatsEyeXI deleted the mob_speed_mod branch May 13, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants