Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] BCNM Royal Jelly - Do not spawn queen jelly at start #5604

Merged
merged 1 commit into from
May 4, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 3, 2024

princess jelly code cleanup

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

The Queen Jelly should not spawn when the battlefield starts. Before this PR if you kill the queen, the princesses go to the middle, then spawn a the queen again.

After that queen dies, no chest would spawn

This PR also cleans up a whole lot of extraneous calls to queryZoneEntities

Did the battlefield simulatenous with two solo players as well to confirm that works

Steps to test these changes

zone to waughroon
!togglegm
enter Royal Jelly
do fight, see that you can win by killing all the princesses, or !exec target:setSpeed(60) (to get them to the center faster) and see that they merge properly and you get armory crate when queen dies

princess jelly code cleanup
@claywar claywar merged commit 51f9b3c into LandSandBoat:base May 4, 2024
10 of 11 checks passed
@CatsEyeXI CatsEyeXI deleted the royal_jelly branch May 13, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants