Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP] Fix Random Deal crashing zone when used with trusts #5608

Merged
merged 1 commit into from
May 4, 2024

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 4, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Currently while having trusts out in combat acting (casting/JA/etc.) then using Random Deal will cause the zone to crash. To resolve this issue we will add a check to ensure the recast packet is only sent for PCs.

Steps to test these changes

  1. !changejob 17 99
  2. Summon trusts
  3. !immortal a mob and attack it
  4. Use Random Deal while the trusts are attacking/using abilities
  5. !reset if necessary

@claywar claywar merged commit f97beee into LandSandBoat:base May 4, 2024
12 checks passed
@ampitere ampitere deleted the fix_random_deal_crashing_zone branch May 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants