Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Shift-proof all "S" zones #5609

Merged
merged 8 commits into from
May 4, 2024
Merged

Conversation

Frankie-hz
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Shift proof the following zones:
Southern San dOria and [S]
South Gustaberg
All Ships
Selbina
Sealions Den
Sea Serpent Grotto
Sauromugue Champaign and [S]
Sacrarium

One thing to note about South Gustaberg is the PHs for Carnero are most likely wrong which is why it looks weird. Will require retail testing but its most likely just the two sheep before the NM ids. I left it as-is for now.
image

Steps to test these changes

Lotto NMS

Sealions Den - A Warriors Path
!addmission 6 748
Iron Gate : !pos 612 132 774 32
Watch CS
Enter fight
See Tenzen fight works

Sacrarium
Change race to Hume :D
!gotoid 16892097
!exec player:setCharVar("FOMOR_HATE", 51)
!additem fomor_codex
Trade to the stale draft, see NM spawn

@claywar claywar merged commit 2a3c2d4 into LandSandBoat:base May 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants