[LUA] Fix Quick Draw improperly calculating resistance #5610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Currently Quick Draw elemental shots (and other magical abilities) do not properly calculate a mob's resistance. For example, if you use Fire Shot on a Fire Elemental it will deal full damage, the same damage as any other elemental shot, and the resist value will be 1. To resolve this we will reuse the xi.combat.magicHitRate.calculateResistRate which does properly account for mob's resistances.
There's a decent amount of code duplication that exists between scripts/globals/combat/magic_hit_rate.lua and scripts/globals/magic.lua, but I have left that for now as this minor change resolves resistances flat out not working.
Steps to test these changes