Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Create Checks for obtaining Halver Alter Ego #5612

Merged
merged 1 commit into from
May 4, 2024

Conversation

hooksta4
Copy link
Contributor

@hooksta4 hooksta4 commented May 4, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Implements a check established in xi.settings.main.ENABLE_TRUST_QUESTS for obtaining all instances of Cipher_Of_Halvers_Trust_Alter_Ego

Checks for xi.settings.main.ENABLE_TRUST_QUESTS 1|0

Steps to test these changes

Pick a nation and add mission 2-3.
Speak with NPC's at consulate and then talk to Halver.
If xi.settings.main.ENABLE_TRUST_QUESTS is 1 player will receive scroll.
if xi.settings.main.ENABLE_TRUST_QUESTS is 0 players will not receive scroll.

@hooksta4 hooksta4 changed the title [LUA] Checks for Halver trust in missions/quests [LUA] Create Checks for obtaining Halver Alter Ego May 4, 2024
@claywar claywar merged commit d851c20 into LandSandBoat:base May 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants