Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Add Prester latent effect functionality #5619

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 5, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds Prester's latent effect functionality. Prester works identically to Breeze Gorget/Belt so we simply add the proper checks for the weapon and wind element on the weaponskill then add the 0.1 fTP bonus if everything matches up.

https://www.bg-wiki.com/ffxi/Prester

Steps to test these changes

  1. !addallweaponskills
  2. !additem 18598
  3. !immortal a mob
  4. !setmod regain 3000 or !godmode
  5. Use a Fragmentation or Detonation weaponskill

@claywar claywar merged commit 52a09f8 into LandSandBoat:base May 8, 2024
12 checks passed
@ampitere ampitere deleted the add_prester_latent_effect_functionality branch May 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants