Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Fix error in xi.mobskills.applyPlayerResistance #5620

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 5, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Due to my recent refactor of getMagicResist there is currently an error when xi.mobskills.applyPlayerResistance runs since it's not using the updated parameters for the method. To fix this we'll just update the method to use the updated parameters.

[05/04/24 23:11:47:198][map][error] luautils::onMobWeaponSkill (mobskill) .\scripts/globals/combat/magic_hit_rate.lua:403: attempt to index local 'target' (a nil value)
stack traceback:
	.\scripts/globals/combat/magic_hit_rate.lua:403: in function 'applyPlayerResistance'
	.\scripts/globals/mobskills.lua:710: in function 'mobStatusEffectMove'
	./scripts/actions/mobskills/sonic_boom.lua:12: in function <./scripts/actions/mobskills/sonic_boom.lua:11> (luautils::OnMobWeaponSkill:3842)

Steps to test these changes

  1. Find a mob
  2. !exec target:useMobAbility(393)

@zach2good zach2good merged commit cdc14fa into LandSandBoat:base May 5, 2024
12 checks passed
@ampitere ampitere deleted the fix_error_in_xi.mobskills.applyPlayerResistance branch May 5, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants