Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Fix Stegotaur and Teratotaur resetting fomor hate #5621

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 5, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Local vars cannot be stored in negative numbers, -4 currently translates to 4294967292 when checked in the fomor hate mixin. The mixin handles non-family types and makes the adjustment negative already so we just need to remove the negative from the local var set on the Stegotaur and Teratotaur.

Steps to test these changes

  1. !pos 100 -2 -41 28
  2. !setplayervar name FOMOR_HATE 60
  3. Kill Teratotaur or Stegotaur
  4. !checkvar FOMOR_HATE

image

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way we handle this makes no sense at all.

In any case, could you add a comment next to those lines, to indicate those values are substracted elsewhere?

@ampitere ampitere force-pushed the fix_teratotaur_resetting_fomor_hate branch from 797638e to f1ee334 Compare May 5, 2024 19:13
@ampitere
Copy link
Contributor Author

ampitere commented May 5, 2024

The way we handle this makes no sense at all.

In any case, could you add a comment next to those lines, to indicate those values are substracted elsewhere?

Added comments that the values are treated as negative in the fomor_hate mixin.

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY sir

@claywar claywar merged commit 3e4ddeb into LandSandBoat:base May 8, 2024
11 checks passed
@ampitere ampitere deleted the fix_teratotaur_resetting_fomor_hate branch May 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants