Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Improve Accuracy of Minuet After Retail Testing #5623

Merged
merged 1 commit into from
May 8, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 5, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Continuation of this PR. We had someone with a brd on retail collect more information for minute 1-4.

The wiki is updated with their results, this PR corrects the divisors to reflect accurate skill caps (i.e. skill that causes the potency to max out)

Steps to test these changes

Similar to last time, force your combined skill to a particular amount and confirm the attack mod you get

@claywar claywar merged commit e3cf9cb into LandSandBoat:base May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants