Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Fixes to chigoe mixins #5626

Merged
merged 1 commit into from
May 8, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 5, 2024

spawn on mobskill behavior in various zones
do not drop loot when instagib happens

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

The chigoe mixin for spawning chigoe pets on Marid mobskills had a few issues:

  • they didn't spawn engaged
  • they never went away
  • they had duplicate code (every instance of a chigoe being spawned by this chigoe_pet mixin already has a Chigoe.lua that defines the instagib behavior)

This PR resolves those

Separately, the chigoe mixin did not properly set no_drop on the mobs when they are set to not give xp

Steps to test these changes

Go to the zones that have chigoe_pet mixin mobs (no idea why that diremite has the mixin, afaict it isn't supposed to spawn chigoes on mobskills?).
image

Confirm when they mobskill a chigoe spawns and immediately aggros/has proper chigoe behavior

https://imgur.com/nxVM12q

spawn on mobskill behavior in various zones
do not drop loot when instagib happens
@claywar claywar merged commit e552105 into LandSandBoat:base May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants