[core] Allow targetfind to reject matching allegiances for ENEMY search

[WinterSolstice8]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This fixes an issue where due to some odd conditions Yagudo could sweep themselves, stun themselves, and break their states causing a crash.
Fixes #5618

Steps to test these changes

See #5618
Also test bomb toss suicide !exec target:useMobAbility(592) and see it works
Test moonlight, curaga, firaga, see them all work.

[WinterSolstice8]

This touches a lot of stuff, gotta make sure it doesn't break anything, added hold label

[WinterSolstice8]

Yup looks like some stuff broke because targetflags != findflags. it fixed my exact bug but some AoEs stopped working. Time to add targetflags into targetfind

We already do some jank conversions from targetflags -> findflags, so makes me wonder if it just should have been this way to begin with...

Updated code

[WinterSolstice8]

Alright, go ahead and re-review. had to touch more stuff

[zach2good]

Can we use the enum values here instead of 0s please?

FINDFLAGS_NONE etc

[WinterSolstice8]

there isnt an enum for targettype value 0

[WinterSolstice8]

enum TARGETTYPE
{
    TARGET_SELF                    = 0x01,
    TARGET_PLAYER_PARTY            = 0x02,
    TARGET_ENEMY                   = 0x04,
    TARGET_PLAYER_ALLIANCE         = 0x08,
    TARGET_PLAYER                  = 0x10,
    TARGET_PLAYER_DEAD             = 0x20,
    TARGET_NPC                     = 0x40, // an npc is a mob that looks like an npc and fights on the side of the character
    TARGET_PLAYER_PARTY_PIANISSIMO = 0x80,
    TARGET_PET                     = 0x100,
    TARGET_PLAYER_PARTY_ENTRUST    = 0x200,
    TARGET_IGNORE_BATTLEID         = 0x400, // Can hit targets that do not have the same battle ID
};

[zach2good]

No reason you can't add FINDFLAGS_NONE, rather than piping in a raw number that means the same thing

[zach2good]

or TARGET_NONE, whatever

[zach2good]

Then the storage and the argument types become the enum:

    FIND_TYPE m_findType;
    FINDFLAGS    m_findFlags;   // what to search for
    TARGETTYPE    m_targetFlags; // targetflags to reject potentially bad targets

[WinterSolstice8]

Then the storage and the argument types become the enum:

    FIND_TYPE m_findType;
    FINDFLAGS    m_findFlags;   // what to search for
    TARGETTYPE    m_targetFlags; // targetflags to reject potentially bad targets

Apparently implementing this is editing a ton of stuff and I don't really have time to test every single permutation of spell/ability/mobskill/petskill right now

I've made the other changes asked of, though.

[zach2good]

Yeah, that one was a "we should probably do this at some point" thing, currently looks good 👍