[core] Implement supertanking #5632
Conversation
|
|
||
| // TODO: Supertanking might be effected by this block when we don't want it to be. | ||
| // Things like Ambuscade "don't have" supertanking, though. | ||
| // This block apparently only effects rare things like NW apollyon, so might be ok for now. |
There was a problem hiding this comment.
So this is a pretty bad implementation of alliance hate, where mobs will aggro the rest of the party if its target dies even if they haven't acted at all. I think an example of something that has this and supertanking is Divine Might. The implementation is bad and will need to be changed, but there should be a way to add a player to a mobs "I'm gonna mess you up when I'm done with this guy" list while still allowing supertanking.
There was a problem hiding this comment.
In LSB this mod is only used in Apollyon NW on the last floor
There was a problem hiding this comment.
It never got widely implemented, mostly because it wasn't a great implementation but worked well enough in Limbus. I did think it was being used in more than just the 1 battlefield though.
There was a problem hiding this comment.
Hmm. Maybe I didn't look hard enough?
There was a problem hiding this comment.
It looks like it was part of the battlefield mob setup functions in mobutils but was apparently removed probably when that Limbus rewrite went in. I'm surprised NW is still left over. Either way there should exist a way for a mob to have a backup list of targets while still allowing supertanking. Not making any request here and if it was up to me I'd say just rip out any remnants of the existing alli_hate_mobmod. It's kind of obscure anyway and having working supertanking is more important right now.
There was a problem hiding this comment.
There's plans in the works to get better enmity systems, stay tuned
There was a problem hiding this comment.
Yeah so I looked and this mod isn't even being used uniformly for all the mobs in the zone, just the last floor in NW and the first floor in NE. Weird, it should all just be removed.
I affirm:
What does this pull request do?
Implements supertanking
Closes #5542
Steps to test these changes
Do supertank things, like aggro/spawn stuff and see that supertanking works, for example:
2024-05-05.21-01-54.webm