[Mission] Sandy 6-2 Adds table and npcUtil.popFromQM & shift proof popped NM #5633
+21
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hooksta4
changed the title
hooksta4
force-pushed
the
KRT_sandy_6_2
branch
3 times, most recently
from
fcb7270
to
9a1ae21
Compare
Frankie-hz
reviewed
May 8, 2024
Comment on lines
24
to
26
| } | ||
| mission.reward = |
There was a problem hiding this comment.
Nitpick: can you add a space between these :)
There was a problem hiding this comment.
Anything for you my friend.
Xaver-DaRed
reviewed
May 8, 2024
| mission:setVar(player, 'Option', 1) | ||
| else | ||
| player:setMissionStatus(mission.areaId, 5) | ||
| end | ||
| end, | ||
|
|
||
| [425] = function(player, csid, option, npc) | ||
| if npcUtil.giveItem(player, { { xi.item.PICKAXE, 3 } }) then |
There was a problem hiding this comment.
Why are this being reverted? Wasnt there a PR precisely for this to be set at 3?
There was a problem hiding this comment.
because I suck at github.
claywar
reviewed
May 11, 2024
| @@ -16,6 +16,13 @@ local krtID = zones[xi.zone.KING_RANPERRES_TOMB] | |||
|
|
|||
| local mission = Mission:new(xi.mission.log_id.SANDORIA, xi.mission.id.sandoria.RANPERRES_FINAL_REST) | |||
|
|
|||
| local ranparesRestTable = | |||
| not GetMobByID(krtID.mob.CORRUPTED_YORGOS):isSpawned() and | ||
| not GetMobByID(krtID.mob.CORRUPTED_SOFFEIL):isSpawned() and | ||
| not GetMobByID(krtID.mob.CORRUPTED_ULBRIG):isSpawned() | ||
| npcUtil.popFromQM(player, npc, ranparesRestTable, { claim = true, hide = 0, }) |
There was a problem hiding this comment.
Does this have an impact if sneak pulling? Which is possible here
There was a problem hiding this comment.
Good point - removing the claim = true should negate that.
| @@ -2,4 +2,5 @@ local ID = zones[xi.zone.KING_RANPERRES_TOMB] | |||
|
|
|||
| return { | |||
| ['_5a0'] = { messageSpecial = ID.text.HEAVY_DOOR }, | |||
| ['Tombstone'] = { messageSpecial = ID.text.A_TOMB }, | |||
[Mission] Sandy 6-2 [Mission] Sandy 6-2 [Mission] Sandy 6-2 Adds table [Mission] Sandy 6-2 table, npcUtil default diaglog [Mission] Sandy 6-2 Adds table and npcUtil.popFromQM & shift proof popped NM [Mission] Sandy 6-2 Adds table and npcUtil.popFromQM & shift proof popped NM [Mission]Ranperres_Final_Rest added table for mobs/shift proff Co-Authored-By: Frank <105882754+Frankie-hz@users.noreply.github.com> Co-Authored-By: Abdiah <62350957+dallano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Makes Sandy mission 6-2 shift proof for IDs (GetFirstID) for each of the 3 spawned mobs in KRT.
Adds table of mobs and moves to npcUtil.popFromQM
Steps to test these changes
!addmission 0 17
!setmissionstatus [NAME] 1 0
!pos -39 4.823 20 190
Click on door and FIGHT the mobs (!hp 0 will not progress missionstatus Var.
After death click door, will then ask to enter door. Select yes and then click the tombstone for KI Ancient Sandorian Book