Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Adjust accVaries to reduce accuracy not hitrate #5639

Merged
merged 1 commit into from
May 8, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 7, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

I know there are comments that accVaries is possibly not implemented properly, but the current intention of the param is to reduce accuracy by a percent based on TP:
image

The current code reduces hitRate by the percent of accuracy (ranged or physical depending on the ws), but it ignores the evasion. I think someone was trying to be clever by utilizing the same divisor as the getHitRate functions (acc - eva)/200, but the result is that hitRate reduction is only a function of accuracy, meaning the explicit hitRate penalty is increased as player accuracy increases.

This PR rearranges the accVaries consideration to before hitRate is calculated and adjusts the calcParams.bonusAcc value.

Note that previous code had a param to not cap hitRate at 95% so accVaries could be considered later, then clamped hitRate. So this new code is functionally the same there.

Steps to test these changes

Ensure dancer steps, desperate flourish, and violent flourish work, as they utilize xi.weaponskills.getHitRate

add a print in the getRangedHitRate and xi.weaponskills.getHitRate functions to view the hitrate and bonusacc to verify things are working as expected.

image
^^ first is the physical first hit's hitrate due to +100 acc. Second is regular hitrate

Copy link
Member

@WinterSolstice8 WinterSolstice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this acc varies with tp nonsense needs to get figured out. one day it will activate my autism hard enough that i'll research every single one I can
I simply do not believe all of these are accuracy penalties. there just isn't any evidence for it.

@claywar claywar merged commit c348aaa into LandSandBoat:base May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants