Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Shift-proof "R" Zones #5640

Merged
merged 6 commits into from
May 8, 2024
Merged

Conversation

Frankie-hz
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Shift-proof the following zones:
Ruhotz Silvermines
Rolanberry Fields and [S]
Riverne Site A 01 and B 01
Ranguemont Pass
Rala Waterways U
RoMaeve

Steps to test these changes

All lotto NMs, one ID change to a quest.

@Frankie-hz
Copy link
Contributor Author

For Ranguemont Pass I wasn't sure how to do Taisaijin without making a global.
Same for the qm positions in RoMaeve.

I can make a global file unless anyone has any other ideas I am not seeing.

@TeoTwawki
Copy link
Contributor

For Ranguemont Pass I wasn't sure how to do Taisaijin without making a global. Same for the qm positions in RoMaeve.

I can make a global file unless anyone has any other ideas I am not seeing.

In the case of Taisaijin ..we should probably have a standardized global way of handling that type of spawn: its a "don't kill my PH for this duration" deal, and there are several NM like that, some with 2 tiers (HQ NM of the NQ NM is left alone even longer) we have lotto pop mechanics globalized in mobs.lua I think it'd be worth giving these a similar treatment. That's outside the scope of your current PR'ings of shift proofing though. What you have atm is fine.

🤔
For "moving" QM (these mostly needed renamed btw, qm_what_am_I_for_exactly) NPC we should have a utils thing for both the kind where its just switching one off and another on, and the kind where the same npc id actually is setPos()'d ..I think we may have something for the latter style already, not sure if it would fit here. Obv that still needs fed id info though.

It's also fine for some of these to stay in IDs.lua, we just won't keep things there unless we really need to - if its all self contained in one script, by by IDs entry. if we need it in several places? it can stay.

@cocosolos
Copy link
Contributor

cocosolos commented May 7, 2024

Idk if there's a util but misareaux coast has a similar qm. It doesn't move around but it does execute some logic at set hours. This one looks like it's supposed to move every 6 hours. If it moves on the hour then a similar approach could be used.

Edit:
Rabbit Footprint in Uleguerand range is probably a better example.

@Frankie-hz
Copy link
Contributor Author

Idk if there's a util but misareaux coast has a similar qm. It doesn't move around but it does execute some logic at set hours. This one looks like it's supposed to move every 6 hours. If it moves on the hour then a similar approach could be used.

Edit: Rabbit Footprint in Uleguerand range is probably a better example.

Ok I will make a note for these cases and submit a PR at the end with commits separating them.

@claywar claywar merged commit 52fdf8d into LandSandBoat:base May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants