[Quest]Distant Loyalties and associated quests #5643
Conversation
| @@ -20,7 +20,9 @@ quest.sections = | |||
| check = function(player, status, vars) | |||
| return status == xi.questStatus.QUEST_AVAILABLE and | |||
| player:hasCompletedQuest(xi.questLog.BASTOK, xi.quest.id.bastok.THE_ELVAAN_GOLDSMITH) and | |||
| player:getFameLevel(xi.fameArea.BASTOK) >= 2 | |||
| player:getFameLevel(xi.fameArea.BASTOK) >= 2 and | |||
| player:getQuestStatus(xi.questLog.SANDORIA, xi.quest.id.sandoria.DISTANT_LOYALTIES) ~= xi.questStatus.QUEST_ACCEPTED | |||
There was a problem hiding this comment.
Not sure if this is really the case, or if we should be using event priority more effectively. Not a problem for now, but a bigger discussion in the future.
There was a problem hiding this comment.
The capture wouldn't let me flag quest while I had it loaded. Uses the same NPC - spoke to it multiple times, but I agree there might be some priority for others...
| @@ -40,7 +42,8 @@ quest.sections = | |||
| ( | |||
| status == xi.questStatus.QUEST_COMPLETED and | |||
| player:getFameLevel(xi.fameArea.BASTOK) == 1 and | |||
| not quest:getMustZone(player) | |||
| not quest:getMustZone(player) or | |||
There was a problem hiding this comment.
This logic looks a bit loose by tacking that or on in the end of 3 and conditions. Even if not necessary, it should probably be clarified with parens
| { | ||
| check = function(player, status, vars) | ||
| return status == xi.questStatus.QUEST_AVAILABLE and | ||
| player:getFameLevel(xi.fameArea.SANDORIA) >= 4 |
There was a problem hiding this comment.
Please indent for this line
|
|
||
| quest.reward = | ||
| { | ||
| fame = 30, |
There was a problem hiding this comment.
Just for styling, can you please align the ='s
| ['Femitte'] = | ||
| { | ||
| onTrigger = function(player, npc) | ||
| local questProgress = quest:getVar(player, 'Prog') |
There was a problem hiding this comment.
No need to define this as a var here, since its only used in one of the conditions
| { | ||
| onTrade = function(player, npc, trade) | ||
| if | ||
| npcUtil.tradeHasExactly(trade, xi.item.MYTHRIL_INGOT) and |
| onEventFinish = | ||
| { | ||
| [315] = function(player, csid, option, npc) | ||
| player:delKeyItem(xi.ki.GOLDSMITHING_ORDER) |
There was a problem hiding this comment.
Is this silent on retail or displayed?
| [317] = function(player, csid, option, npc) | ||
| player:confirmTrade() | ||
| quest:setVar(player, 'Prog', 2) | ||
| player:needToZone(true) |
There was a problem hiding this comment.
Convention is to use the quest's setMustZone function. needToZone is too generic.
[Quest]Distant Loyalties and associated quests [Quest]Distant Loyalties and associated quests
|
@claywar - made the changes you requested. |
I affirm:
What does this pull request do?
Implements sandy quest Distant Loyalties
Capture
Steps to test these changes
Get Fame 4 in sandy. Speak with Femitte accept quest. Travel to Bastok Markets, NPC Michea will not give Father Figure or The Elvaan Goldsmith until completed.
Complete quest and then can accept The elvaan goldsmith and father figure.