Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packet] Implement C->S 0x119, S->C 0x11A - Emote List #5644

Merged
merged 1 commit into from
May 7, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 7, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements 0x119 Client request (Emote List Request) and 0x11A Emote List

Steps to test these changes

  1. Check Menu->Communication->Emote List (Job Emote)
  2. Add Key Item for Job Gesture Scholar
  3. Check Menu->Communication->Emote List (Job Emote)
  4. Add Key Item for Job Gesture RUN
  5. Check Menu->Communication->Emote List (Job Emote)
  6. Add Chocobo Chair II Key Item
  7. Check Menu->Communication->Emote List (Sit Chair)

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventive approval. But CI is complaining about some style.

@claywar claywar merged commit 576c585 into base May 7, 2024
11 checks passed
@claywar claywar deleted the packet/s2c-0x011a branch May 7, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants