Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix issue with !togglegm status not persisting correctly #5648

Merged

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

fixes #5636
Basically the code was just always turning on GM mode when you zoned because it was accessing the wrong variable (your gm mode, not what you set as visible gm)

Steps to test these changes

use !togglegm, with gm mode on when you zone, and see it persist.
use !togglegm, with gm mode off when you zone, and see gm mode not be on (instead of on all the time)

@zach2good zach2good merged commit f2c3675 into LandSandBoat:base May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Losing !togglegm upon zoning
4 participants