Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua] Update !getstats to partition reports #5653

Merged
merged 1 commit into from May 11, 2024

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented May 8, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Per this thread, I've updated the !getstats command

It now collects all the messages to print into a table and spits them out at the end, to reduce duplicated code

Went through a lot of iterations, but suffice to say the help text shows up when you don't choose a proper stat group, and it still prints all the same data, as well as a whole new group of "elements" with resistance data as well as immunities.

Steps to test these changes

image

image

image

@MowFord
Copy link
Contributor Author

MowFord commented May 8, 2024

rebased after enum changes

image

@MowFord MowFord force-pushed the getstats_improvements branch 3 times, most recently from ea7abea to 52e91ad Compare May 8, 2024 23:19
@MowFord
Copy link
Contributor Author

MowFord commented May 9, 2024

switch:caseof works with a default block, neat

@TeoTwawki
Copy link
Contributor

switch:caseof works with a default block, neat

whats even neater is this is probably the 1st time anyone has used it. which was why I stamped before hand lol.

@MowFord MowFord closed this May 9, 2024
@MowFord MowFord deleted the getstats_improvements branch May 9, 2024 14:11
@MowFord MowFord restored the getstats_improvements branch May 9, 2024 14:16
@MowFord MowFord reopened this May 9, 2024
@MowFord
Copy link
Contributor Author

MowFord commented May 9, 2024

When cleaning up goes too far, sorry about that. Accidentally deleted the branch

@Frankie-hz
Copy link
Contributor

Love this idea

@claywar claywar merged commit 73ce289 into LandSandBoat:base May 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants