New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lua] Update !getstats to partition reports #5653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaver-DaRed
approved these changes
May 8, 2024
MowFord
force-pushed
the
getstats_improvements
branch
from
May 8, 2024 21:33
8db75de
to
78369ab
Compare
TeoTwawki
reviewed
May 8, 2024
TeoTwawki
reviewed
May 8, 2024
TeoTwawki
reviewed
May 8, 2024
MowFord
force-pushed
the
getstats_improvements
branch
3 times, most recently
from
May 8, 2024 23:19
ea7abea
to
52e91ad
Compare
TeoTwawki
approved these changes
May 8, 2024
MowFord
force-pushed
the
getstats_improvements
branch
from
May 9, 2024 00:01
52e91ad
to
72fae77
Compare
switch:caseof works with a default block, neat |
whats even neater is this is probably the 1st time anyone has used it. which was why I stamped before hand lol. |
When cleaning up goes too far, sorry about that. Accidentally deleted the branch |
Love this idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Per this thread, I've updated the
!getstats
commandIt now collects all the messages to print into a table and spits them out at the end, to reduce duplicated codeWent through a lot of iterations, but suffice to say the help text shows up when you don't choose a proper stat group, and it still prints all the same data, as well as a whole new group of "elements" with resistance data as well as immunities.
Steps to test these changes