Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Correct Immunity enum and apply it where it belongs #5654

Merged
merged 2 commits into from
May 8, 2024

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented May 8, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Correct immunity enum, that was using c++ style, as oposed to what was being used in scripts, which was what one would expect, when looking at any other enum.
  • Apply enum to scripts which werent using them.
  • Add Petrify immunity to Break and Breakga checks.

Steps to test these changes

No changes should be observed, other than break spells now failing on petrify-immune enemies.

@claywar claywar merged commit a0e7756 into LandSandBoat:base May 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants