Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Reraise' on Job Change #5655

Merged
merged 1 commit into from
May 8, 2024

Conversation

CatsEyeXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Properly removes Reraise when changing jobs.
Verified on retail by casting reraise on self as WHM, then using Nomad Moogle in Selbina to change jobs to RDM, effect was removed.

Steps to test these changes

!changejob WHM 99
/ma "Reraise"
Use Nomad Moogle in Selbina to change jobs
Effect will disappear.

@TeoTwawki
Copy link
Contributor

wow seriously we were leaving rr on this whole time? I wonder how far back that mistake started.

@claywar claywar merged commit 72a9cef into LandSandBoat:base May 8, 2024
12 checks passed
@CatsEyeXI CatsEyeXI deleted the reraise_effectflag branch May 9, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants