Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Fix Shattering Stars BCNMs should restrict subjob #5665

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 9, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

The Shattering Stars BCNMs are currently being converted into the new battlefield framework but are missing the parameter to disable subjobs. This causes players to be able to use their subjob during the BCNM which should not be possible.

Steps to test these changes

  1. !changejob 11 99
  2. !additem 1436
  3. !zone Horlais Peak
  4. Trade the testimony to the Burning Circle

Copy link
Contributor

@claywar claywar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this was a miss on my part. I was looking for rulemask settings for a more generic conversion, so expect this method of defining will change in the future

Though since this is a logical or, there may be a greater issue of first not starting with the fully-defined ruleset

@ampitere ampitere force-pushed the fix_shattering_stars_restricts_subjob branch from 2a5c10a to d38dd82 Compare May 9, 2024 19:34
@claywar claywar merged commit 25ce923 into LandSandBoat:base May 11, 2024
11 checks passed
@ampitere ampitere deleted the fix_shattering_stars_restricts_subjob branch May 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants