Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMK, Lua] Loops fixed, formatting fixes, added comment #5670

Merged

Conversation

Flibe-XI
Copy link
Contributor

@Flibe-XI Flibe-XI commented May 9, 2024

Added comment describing table in mission 9 (rescue) Changed loops to use enum values

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Addresses comments in #5551 . Loops in mission 9 to use enum values, added comment to describe the markerset matrix, misc formatting.

Steps to test these changes

!addmission 10 8
collect key items for navaratna talisman in quicksand caves

Changed loop from range to enums
@claywar claywar merged commit 8abf200 into LandSandBoat:feature/amk_missions May 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants