Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbtool] Add migration to verify/fix char_flags count #5672

Merged

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes root cause of #5663
If char_flags row count is less than char row count, that means the previous migration (or some other anomaly) failed before this PR to fix the previous migration fix #5647

The query it runs is safe to repeatedly run.

Steps to test these changes

run dbtool.py migrate, see it work if you need it, and to skip if you don't.

@claywar claywar merged commit 0a7cf4a into LandSandBoat:base May 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants