Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Fix Tenshodo Coffer uses KI when reward is unobtainable #5685

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 11, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes an issue with the Tenshodo Coffer where the KI will be consumed even if a player cannot receive the current reward item. player:addItem returns whether or not it was successful so we just need to flip the if..then logic and add it there. Resolves #4727

Steps to test these changes

  1. !pos 41.169 3.899 -51.005 245
  2. !addkeyitem 1184
  3. !additem 4751
  4. Open until you get a Scroll of Erase or your inventory is full

@ampitere ampitere force-pushed the fix_tenshodo_coffer_uses_ki_when_item_unobtainable branch from ac5c7f3 to 2bb4455 Compare May 11, 2024 03:35
@claywar claywar merged commit 8501e4c into LandSandBoat:base May 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Tenshodo Coffer eat key items when item cannot be obtained
2 participants