Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add utility method to get highest job level of char #5686

Merged

Conversation

TracentEden2
Copy link

@TracentEden2 TracentEden2 commented May 11, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR adds a utility function to get the highest level of all jobs of a char. This is useful for implementing retail logic such as fishing fatigue being different if chars highest level is less than 20 (see retail patch notes). This is also useful for private servers that can use the function to implement restrictions to avoid spammers and bots. For example Horizon implements a min highest level of 20 for using yell and for fishing.

Steps to test these changes

There is no user facing LSB implementation as of yet (as fishing data for example is not fully known). Thus one way to test is to add code to like zoning logic that prints to the player their highest level, the test by zoning.

Co-authored-by: OpheliaXI <heliashelium@gmail.com>
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see why not. Simple loop.

@claywar claywar merged commit 3755039 into LandSandBoat:base May 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants