Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup]Standardize AF Quest Names #5687

Merged
merged 1 commit into from
May 12, 2024

Conversation

hooksta4
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Standardizes all current Artifact Quests into [JOB]AF[1-3]Quest_Name
Adjusted quests that were not using player:getMainLvl() >= xi.settings.main.AF[X]_QUEST_LEVEL

Standardizes naming Convention

Steps to test these changes

None should be noted. Renamed files.

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve couse I was the one who started this trend.

However, from this point on, I believe we should stick to just "Those questlines everyone does". Aka, Limit breaks and AFs

@claywar
Copy link
Contributor

claywar commented May 11, 2024

Apologies, but a rebase will be required here due to corrections in that quest script

@hooksta4
Copy link
Contributor Author

Apologies, but a rebase will be required here due to corrections in that quest script

Did I finally do it correctly?

@hooksta4
Copy link
Contributor Author

I'm gonna approve couse I was the one who started this trend.

However, from this point on, I believe we should stick to just "Those questlines everyone does". Aka, Limit breaks and AFs

Yea I don't think there are any more quest series that are more than a few long that would really warrant these. The ones that come to mind are already done, The Onions series, Rycharde chef... I mean maybe the ToAU mythic questline?

@claywar claywar merged commit 7790025 into LandSandBoat:base May 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants