Fix "A Thief in Norg?!" content group IDs #5689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claywar
force-pushed
the
bugfix/thief-in-norg-moblist
branch
2 times, most recently
from
0999914
to
e917d32
Compare
|
Good to go now, Ayakashi will spawn appropriately, though until a separate PR goes in, if GM is enabled, you won't get the ability triggered. |
| (vanadielHour > 18 or vanadielHour < 5) and | ||
| not GetMobByID(valkurmID.mob.DOMAN):isSpawned() and | ||
| not GetMobByID(valkurmID.mob.ONRYO):isSpawned() | ||
| (vanadielHour > 18 or vanadielHour < 5) |
There was a problem hiding this comment.
Is this supposed to be 19 to 4 or 18 through 5? (>= and <= or > and <)
There was a problem hiding this comment.
Definitely should be >=/<, good catch
claywar
force-pushed
the
bugfix/thief-in-norg-moblist
branch
2 times, most recently
from
0235dac
to
576fe5b
Compare
Turn off pet spawn, since mob_pets spawn automatically Add missing variable to getVar Fix default actions for SAM AF2, AF3 Correct spawn points, add additional NPCs for Waughroon Shrine Add jobspecial mixin for enemies Add missing mob entries, cleanup groups Remove avatars from required group Fix conditional for Yomi Okuri timing Fix conditional again
claywar
force-pushed
the
bugfix/thief-in-norg-moblist
branch
from
576fe5b
to
4d3da59
Compare
Xaver-DaRed
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Steps to test these changes
Run through this battlefield in all areas. Note: Additional issue raised to support the second avatar that uses Astral Flow in this BCNM.