Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codeql] Fix type confusion warning in battleutils::AddTraits #5693

Merged
merged 1 commit into from
May 11, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 11, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Use dynamic_cast instead of ternary to determine if the entity is CCharEntity

Steps to test these changes

Things still work

@claywar claywar merged commit 63d92c9 into base May 11, 2024
12 checks passed
@claywar claywar deleted the codeql/type-confusion branch May 11, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants